From 98bbdf71f4419440124087ab375d71ccb8efa351 Mon Sep 17 00:00:00 2001
From: michaelachrisco <michaelachrisco@gmail.com>
Date: Wed, 17 Jan 2024 12:04:18 -0800
Subject: [PATCH 1/3] feat(spec): Testing users should have more context

---
 spec/ReadOnlyTraitSpec.php | 329 +++++++++++++++++++------------------
 1 file changed, 166 insertions(+), 163 deletions(-)

diff --git a/spec/ReadOnlyTraitSpec.php b/spec/ReadOnlyTraitSpec.php
index ae22fc4..ac9cdc1 100644
--- a/spec/ReadOnlyTraitSpec.php
+++ b/spec/ReadOnlyTraitSpec.php
@@ -4,172 +4,175 @@ require_once('src/ReadOnlyTrait.php');
 use MichaelAChrisco\ReadOnly\ReadOnlyException;
 use MichaelAChrisco\ReadOnly\ReadOnlyTrait;
 
-class User extends Illuminate\Database\Eloquent\Model {
-  use ReadOnlyTrait;
+class User extends Illuminate\Database\Eloquent\Model
+{
+    use ReadOnlyTrait;
 }
 
-describe("User", function() {
-  describe("::create()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->create([]);
-        })->toThrow(new ReadOnlyException('create', 'User'));
-    });
- });
- describe("::forceCreate()", function(){
-   it("is expected to throw ReadOnlyException", function() {
-     $closure = function(){
-       $user = new User;
-       $user->forceCreate([]);
-     };
-     expect($closure)->toThrow(new ReadOnlyException('forceCreate', 'User'));
-   });
-});
-  describe("::save()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->save([]);
-        })->toThrow(new ReadOnlyException('save', 'User'));
-    });
-  });
-  describe("::update()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->update([]);
-        })->toThrow(new ReadOnlyException('update', 'User'));
-      });
-   });
-  describe("::firstOrCreate()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->firstOrCreate([]);
-        })->toThrow(new ReadOnlyException('firstOrCreate', 'User'));
-    });
-  });
-  describe("::firstOrNew()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->firstOrNew([]);
-        })->toThrow(new ReadOnlyException('firstOrNew', 'User'));
-    });
-   });
-  describe("::delete()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->delete();
-        })->toThrow(new ReadOnlyException('delete', 'User'));
-    });
-   });
-  describe("::destroy()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->destroy(1);
-        })->toThrow(new ReadOnlyException('destroy', 'User'));
-    });
-   });
-  describe("::restore()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->restore();
-        })->toThrow(new ReadOnlyException('restore', 'User'));
-    });
-   });
-  describe("::forceDelete()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->forceDelete();
-        })->toThrow(new ReadOnlyException('forceDelete', 'User'));
-      });
-    });
-   describe("::performDeleteOnModel()", function(){
-     it("is expected to throw ReadOnlyException", function() {
-       expect(
-         function(){
-           $user = new User;
-           $user->performDeleteOnModel();
-         })->toThrow(new ReadOnlyException('performDeleteOnModel', 'User'));
-      });
-    });
-  describe("::push()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-      expect(
-        function(){
-          $user = new User;
-          $user->push();
-        })->toThrow(new ReadOnlyException('push', 'User'));
-     });
-   });
- describe("::finishSave()", function(){
-   it("is expected to throw ReadOnlyException", function() {
-     expect(
-       function(){
-         $user = new User;
-         $user->finishSave([]);
-       })->toThrow(new ReadOnlyException('finishSave', 'User'));
-     });
-  });
-  describe("::performUpdate()", function(){
-    it("is expected to throw ReadOnlyException", function() {
-        $user = new User;
-        //TODO: Mock up
-          // $user = new User;
-          // $user->performUpdate(new Builder, []);
-        unset($user);
-    });
-   });
-   describe("::touch()", function(){
-     it("is expected to throw ReadOnlyException", function() {
-       expect(
-         function(){
-           $user = new User;
-           $user->touch();
-         })->toThrow(new ReadOnlyException('touch', 'User'));
-      });
-    });
-   describe("::truncate()", function(){
-     it("is expected to throw ReadOnlyException", function() {
-       expect(
-         function(){
-           $user = new User;
-           $user->truncate();
-         })->toThrow(new ReadOnlyException('truncate', 'User'));
-      });
-    });
-   describe("::insert()", function(){
-     it("is expected to throw ReadOnlyException", function() {
-       expect(
-         function(){
-           $user = new User;
-           $user->insert();
-         })->toThrow(new ReadOnlyException('insert', 'User'));
-      });
+describe("User", function () {
+    context("When User calls unsupported method", function () {
+        describe("::create()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->create([]);
+                    })->toThrow(new ReadOnlyException('create', 'User'));
+            });
+        });
+        describe("::forceCreate()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                $closure = function () {
+                    $user = new User;
+                    $user->forceCreate([]);
+                };
+                expect($closure)->toThrow(new ReadOnlyException('forceCreate', 'User'));
+            });
+        });
+        describe("::save()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->save([]);
+                    })->toThrow(new ReadOnlyException('save', 'User'));
+            });
+        });
+        describe("::update()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->update([]);
+                    })->toThrow(new ReadOnlyException('update', 'User'));
+            });
+        });
+        describe("::firstOrCreate()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->firstOrCreate([]);
+                    })->toThrow(new ReadOnlyException('firstOrCreate', 'User'));
+            });
+        });
+        describe("::firstOrNew()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->firstOrNew([]);
+                    })->toThrow(new ReadOnlyException('firstOrNew', 'User'));
+            });
+        });
+        describe("::delete()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->delete();
+                    })->toThrow(new ReadOnlyException('delete', 'User'));
+            });
+        });
+        describe("::destroy()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->destroy(1);
+                    })->toThrow(new ReadOnlyException('destroy', 'User'));
+            });
+        });
+        describe("::restore()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->restore();
+                    })->toThrow(new ReadOnlyException('restore', 'User'));
+            });
+        });
+        describe("::forceDelete()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->forceDelete();
+                    })->toThrow(new ReadOnlyException('forceDelete', 'User'));
+            });
+        });
+        describe("::performDeleteOnModel()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->performDeleteOnModel();
+                    })->toThrow(new ReadOnlyException('performDeleteOnModel', 'User'));
+            });
+        });
+        describe("::push()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->push();
+                    })->toThrow(new ReadOnlyException('push', 'User'));
+            });
+        });
+        describe("::finishSave()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->finishSave([]);
+                    })->toThrow(new ReadOnlyException('finishSave', 'User'));
+            });
+        });
+        describe("::performUpdate()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                $user = new User;
+                //TODO: Mock up
+                // $user = new User;
+                // $user->performUpdate(new Builder, []);
+                unset($user);
+            });
+        });
+        describe("::touch()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->touch();
+                    })->toThrow(new ReadOnlyException('touch', 'User'));
+            });
+        });
+        describe("::truncate()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->truncate();
+                    })->toThrow(new ReadOnlyException('truncate', 'User'));
+            });
+        });
+        describe("::insert()", function () {
+            it("is expected to throw ReadOnlyException", function () {
+                expect(
+                    function () {
+                        $user = new User;
+                        $user->insert();
+                    })->toThrow(new ReadOnlyException('insert', 'User'));
+            });
+        });
     });
 });
 
 class MockModel
 {
-  public static function create(array $attributes = [])
-  {
-      return true;
-  }
+    public static function create(array $attributes = [])
+    {
+        return true;
+    }
 }
 
 class UserReadOnlyNotActive extends MockModel
@@ -184,9 +187,9 @@ class UserReadOnlyNotActive extends MockModel
 
 describe("UserReadOnlyNotActive", function () {
     describe("::create()", function () {
-      it("expects `create()` to be toBeTruthy", function() {
-          $user = new UserReadOnlyNotActive;
-          expect($user->create([]))->toBeTruthy();
-      });
+        it("expects `create()` to be toBeTruthy", function () {
+            $user = new UserReadOnlyNotActive;
+            expect($user->create([]))->toBeTruthy();
+        });
     });
 });

From a1dbc560710b5e68984750dfc3cc3a7319d72a9e Mon Sep 17 00:00:00 2001
From: michaelachrisco <michaelachrisco@gmail.com>
Date: Wed, 17 Jan 2024 12:08:41 -0800
Subject: [PATCH 2/3] feat(spec): Testing class with isActive

---
 spec/ReadOnlyTraitSpec.php | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/spec/ReadOnlyTraitSpec.php b/spec/ReadOnlyTraitSpec.php
index ac9cdc1..40b4427 100644
--- a/spec/ReadOnlyTraitSpec.php
+++ b/spec/ReadOnlyTraitSpec.php
@@ -186,10 +186,12 @@ class UserReadOnlyNotActive extends MockModel
 }
 
 describe("UserReadOnlyNotActive", function () {
-    describe("::create()", function () {
-        it("expects `create()` to be toBeTruthy", function () {
-            $user = new UserReadOnlyNotActive;
-            expect($user->create([]))->toBeTruthy();
+    context("When UserReadOnlyNotActive calls unsupported method and isActive is true", function () {
+        describe("::create()", function () {
+            it("expects `create()` to be toBeTruthy", function () {
+                $user = new UserReadOnlyNotActive;
+                expect($user->create([]))->toBeTruthy();
+            });
         });
     });
 });

From f65c32b7f94908917b83b11418b8b354ff31b7d8 Mon Sep 17 00:00:00 2001
From: michaelachrisco <michaelachrisco@gmail.com>
Date: Wed, 17 Jan 2024 12:11:19 -0800
Subject: [PATCH 3/3] fix(circleci): Library should work with php 8.3

---
 .circleci/config.yml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 5bec7cc..f610186 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -19,9 +19,19 @@ jobs:
       - run: sudo composer self-update
       - run: composer install -n --prefer-dist --no-plugins
       - run: ./vendor/bin/kahlan -reporter=verbose
+  build_php_version_83:
+    docker:
+      - image: cimg/php:8.3.0
+    working_directory: ~/ReadOnlyTraitLaravel
+    steps: # a set of executable commands
+      - checkout
+      - run: sudo composer self-update
+      - run: composer install -n --prefer-dist --no-plugins
+      - run: ./vendor/bin/kahlan -reporter=verbose
 workflows:
   version: 2
   build:
     jobs:
       - build_php_version_81
       - build_php_version_82
+      - build_php_version_83