From 3b462377ce608e42b5fb00b48ab1d86ed0c1d8e8 Mon Sep 17 00:00:00 2001
From: rimu <3310831+rimu@users.noreply.github.com>
Date: Sun, 24 Nov 2024 09:19:58 +1300
Subject: [PATCH] move post teaser clickable div so voting buttons still work

---
 app/static/js/scripts.js                     | 2 +-
 app/static/styles.css                        | 3 +++
 app/static/styles.scss                       | 4 ++++
 app/templates/post/post_teaser/_article.html | 4 ++--
 app/templates/post/post_teaser/_link.html    | 4 ++--
 app/templates/post/post_teaser/_poll.html    | 2 +-
 6 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/app/static/js/scripts.js b/app/static/js/scripts.js
index ebc772bf..ae9bac26 100644
--- a/app/static/js/scripts.js
+++ b/app/static/js/scripts.js
@@ -39,7 +39,7 @@ document.addEventListener("DOMContentLoaded", function () {
 function setupPostTeaserHandler() {
     document.querySelectorAll('.post_teaser_clickable').forEach(div => {
         div.onclick = function() {
-            const firstAnchor = this.querySelector('a');
+            const firstAnchor = this.parentElement.querySelector('a');
             if (firstAnchor) {
                 window.location.href = firstAnchor.href;
             }
diff --git a/app/static/styles.css b/app/static/styles.css
index 057ec4ba..cfe92b65 100644
--- a/app/static/styles.css
+++ b/app/static/styles.css
@@ -867,6 +867,9 @@ div.navbar {
 .post_list .post_teaser.blocked .voting_buttons .upvote_button, .post_list .post_teaser.blocked .voting_buttons .downvote_button {
   font-size: 80%;
 }
+.post_list .post_teaser .post_teaser_clickable {
+  cursor: pointer;
+}
 
 .post_teaser_body {
   position: relative;
diff --git a/app/static/styles.scss b/app/static/styles.scss
index 8c3bff6f..7b17739f 100644
--- a/app/static/styles.scss
+++ b/app/static/styles.scss
@@ -460,6 +460,10 @@ div.navbar {
         }
       }
     }
+
+    .post_teaser_clickable {
+      cursor: pointer;
+    }
   }
 }
 
diff --git a/app/templates/post/post_teaser/_article.html b/app/templates/post/post_teaser/_article.html
index ba363f1e..70f3fc55 100644
--- a/app/templates/post/post_teaser/_article.html
+++ b/app/templates/post/post_teaser/_article.html
@@ -1,4 +1,4 @@
-<div class="col post_teaser_body post_teaser_clickable">
+<div class="col post_teaser_body">
     <h3>{% if post.sticky -%}<span class="fe fe-sticky-left"></span>{% endif -%}<a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None) }}" class="post_teaser_title_a">{{ post.title }}</a>
         {% if post.nsfw -%}<span class="warning_badge nsfw" title="{{ _('Not safe for work') }}">nsfw</span>{% endif -%}
         {% if post.nsfl -%}<span class="warning_badge nsfl" title="{{ _('Potentially emotionally scarring content') }}">nsfl</span>{% endif -%}
@@ -13,7 +13,7 @@
         c/{{ post.community.name }}</a>{% endif -%}
         by {{ render_username(post.author) }} <time datetime="{{ post.last_active }}">{{ post.posted_at_localized(sort, locale) }}</time></span>
     {% if post.body_html -%}
-        <div class="post_teaser_article_preview small">
+        <div class="post_teaser_article_preview small post_teaser_clickable">
             {{ first_paragraph(post.body_html) | safe }}
         </div>
     {% endif -%}
diff --git a/app/templates/post/post_teaser/_link.html b/app/templates/post/post_teaser/_link.html
index 1183b969..84360456 100644
--- a/app/templates/post/post_teaser/_link.html
+++ b/app/templates/post/post_teaser/_link.html
@@ -1,4 +1,4 @@
-<div class="col post_teaser_body post_teaser_clickable">
+<div class="col post_teaser_body">
     <h3>{% if post.sticky -%}<span class="fe fe-sticky-left"></span>{% endif -%}<a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None) }}" class="post_teaser_title_a">{{ post.title }}</a>
         {% if post.domain_id -%}
             {% if post.url.endswith('.mp3') -%}
@@ -19,7 +19,7 @@
         c/{{ post.community.name }}</a>{% endif -%}
         by {{ render_username(post.author) }} <time datetime="{{ post.last_active }}">{{ post.posted_at_localized(sort, locale) }}</time></span>
     {% if post.body_html -%}
-        <div class="post_teaser_link_preview small">
+        <div class="post_teaser_link_preview small post_teaser_clickable">
             {{ first_paragraph(post.body_html) | safe }}
         </div>
     {% endif -%}
diff --git a/app/templates/post/post_teaser/_poll.html b/app/templates/post/post_teaser/_poll.html
index f7949b45..5d0c8542 100644
--- a/app/templates/post/post_teaser/_poll.html
+++ b/app/templates/post/post_teaser/_poll.html
@@ -1,4 +1,4 @@
-<div class="col post_teaser_body post_teaser_clickable">
+<div class="col post_teaser_body">
     <h3>{% if post.sticky -%}<span class="fe fe-sticky-left"></span>{% endif -%}<a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None) }}" class="post_teaser_title_a">{{ post.title }}</a>
         <span class="fe fe-poll" aria-hidden="true"> </span>
         {% if post.nsfw -%}<span class="warning_badge nsfw" title="{{ _('Not safe for work') }}">nsfw</span>{% endif -%}