From 55ddc0641fb0f257363dfe0a25589992cac6fdd9 Mon Sep 17 00:00:00 2001
From: rimu <3310831+rimu@users.noreply.github.com>
Date: Wed, 24 Jan 2024 09:52:08 +1300
Subject: [PATCH] wcag tweaks - aria-hidden

---
 app/templates/post/_post_full.html   | 10 ++++------
 app/templates/post/_post_teaser.html | 14 +++++++-------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/app/templates/post/_post_full.html b/app/templates/post/_post_full.html
index 2402fa20..e96736e1 100644
--- a/app/templates/post/_post_full.html
+++ b/app/templates/post/_post_full.html
@@ -21,9 +21,8 @@
                 {% endif %}
             </h1>
             {% if post.url %}
-                <p><small><a href="{{ post.url }}" rel="nofollow ugc" target="_blank">{{ post.url|shorten_url }}
-                <img src="/static/images/external_link_black.svg" class="external_link_icon" alt="External link"  />
-                </a></small></p>
+                <p><a href="{{ post.url }}" rel="nofollow ugc" target="_blank">{{ post.url|shorten_url }}
+                    <span class="fe fe-external"></span></a></p>
             {% endif %}
             <p>{% if post.reports and current_user.is_authenticated and post.community.is_moderator(current_user) %}
                     <span class="red fe fe-report" title="{{ _('Reported. Check post for issues.') }}"></span>
@@ -81,9 +80,8 @@
                 {% if post.edited_at %} edited {{ moment(post.edited_at).fromNow() }}{% endif %}</small>
             </p>
             {% if post.type == POST_TYPE_LINK %}
-                <p><small><a href="{{ post.url }}" rel="nofollow ugc" target="_blank" class="post_link">{{ post.url|shorten_url }}
-                <img src="/static/images/external_link_black.svg" class="external_link_icon" alt="External link" class="post_link" /></a>
-                </small></p>
+                <p><a href="{{ post.url }}" rel="nofollow ugc" target="_blank" class="post_link">{{ post.url|shorten_url }}
+                <span class="fe fe-external"></span></a></p>
                 {% if 'youtube.com' in post.url %}
                     <div style="padding-bottom: 56.25%; position: relative;"><iframe style="position: absolute; top: 0px; left: 0px; width: 100%; height: 100%;" src="https://www.youtube.com/embed/{{ post.youtube_embed() }}?rel=0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture; fullscreen"  width="100%" height="100%" frameborder="0"></iframe></div>
                 {% endif %}
diff --git a/app/templates/post/_post_teaser.html b/app/templates/post/_post_teaser.html
index 56793d26..b1030a67 100644
--- a/app/templates/post/_post_teaser.html
+++ b/app/templates/post/_post_teaser.html
@@ -9,11 +9,11 @@
                     <div class="row main_row">
                         <div class="col">
                             <h3 class="post_teaser_title">
-                                <div class="voting_buttons">
+                                <div class="voting_buttons" aria-hidden="true">
                                     {% include "post/_post_voting_buttons.html" %}
                                 </div>
                                 {% if post.image_id %}
-                                    <div class="thumbnail{{ ' lbw' if low_bandwidth }}">
+                                    <div class="thumbnail{{ ' lbw' if low_bandwidth }}" aria-hidden="true">
                                         {% if low_bandwidth %}
                                             {% if post.type == POST_TYPE_LINK %}
                                                 <a href="{{ post.url }}" rel="nofollow ugc" target="_blank" aria-label="{{ _('Read article') }}"><span class="fe fe-external"></span></a>
@@ -39,10 +39,10 @@
                                     </div>
                                 {% endif %}
                                 <a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None) }}" class="post_teaser_title_a">{{ post.title }}</a>
-                                {% if post.type == POST_TYPE_IMAGE %}<span class="fe fe-image"> </span>{% endif %}
+                                {% if post.type == POST_TYPE_IMAGE %}<span class="fe fe-image" aria-hidden="true"> </span>{% endif %}
                                 {% if post.type == POST_TYPE_LINK and post.domain_id %}
                                     {% if post.url and 'youtube.com' in post.url %}
-                                        <span class="fe fe-video"></span>
+                                        <span class="fe fe-video" aria-hidden="true"></span>
                                     {% endif %}
                                     <span class="domain_link">(<a href="/d/{{ post.domain_id }}" aria-label="{{ _('All posts about this domain') }}">{{ post.domain.name }}</a>)</span>
                                 {% endif %}
@@ -58,13 +58,13 @@
                     </div>
                     <div class="row utilities_row">
                         <div class="col-6">
-                            <a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None, _anchor='post_replies') }}" aria-label="{{ _('View comments') }}"><span class="fe fe-reply"></span></a>
+                            <a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None, _anchor='post_replies') }}" aria-label="{{ _('View comments') }}" aria-hidden="true"><span class="fe fe-reply"></span></a>
                             <a href="{{ url_for('activitypub.post_ap', post_id=post.id, sort='new' if sort == 'active' else None, _anchor='post_replies') }}" aria-label="{{ _('View comments') }}">{{ post.reply_count }}</a>
                             {% if post.type == POST_TYPE_IMAGE %}
                                 {% if post.image_id %}
-                                    <a href="{{ post.image.view_url() }}" rel="nofollow ugc" class="preview_image" aria-label="{{ _('View image') }}"><span class="fe fe-magnify"></span></a>
+                                    <a href="{{ post.image.view_url() }}" rel="nofollow ugc" class="preview_image" aria-label="{{ _('View image') }}" aria-hidden="true"><span class="fe fe-magnify"></span></a>
                                 {% else %}
-                                    <a href="{{ post.url }}" rel="nofollow ugc" class="preview_image" target="_blank" aria-label="{{ _('View image') }}"><span class="fe fe-magnify"></span></a>
+                                    <a href="{{ post.url }}" rel="nofollow ugc" class="preview_image" target="_blank" aria-label="{{ _('View image') }}" aria-hidden="true"><span class="fe fe-magnify"></span></a>
                                 {% endif %}
                             {% endif %}
                         </div>