From 5c274e21ecbecae312a77e922915941d13f50527 Mon Sep 17 00:00:00 2001
From: Nicolas Mailloux <nicolecrivain@gmail.com>
Date: Thu, 2 Sep 2021 19:00:54 -0400
Subject: [PATCH] PDF: minor fixes

---
 reader.cpp |  3 +--
 reader.h   |  2 --
 reader.ui  | 34 +++++++++++++++++-----------------
 3 files changed, 18 insertions(+), 21 deletions(-)

diff --git a/reader.cpp b/reader.cpp
index 50c70b2..714688d 100644
--- a/reader.cpp
+++ b/reader.cpp
@@ -1953,8 +1953,8 @@ void reader::setupLocalSettingsEnvironment() {
 
 void reader::setupPng() {
     // Note: Output file is supposed to be '/run/page.png', but somehow mutool puts it in '/run/page1.png'
-    // QGraphicsScene * graphicsScene = new QGraphicsScene();
     QPixmap pixmap("/run/page1.png");
+    // Initialized above
     graphicsScene->addPixmap(pixmap);
     ui->graphicsView->items().clear();
     ui->graphicsView->setScene(graphicsScene);
@@ -2021,7 +2021,6 @@ void reader::on_pdfScaleSlider_valueChanged(int value)
         }
     }
 
-    mupdf::pdf::pdfPageNumber = mupdf::pdf::pdfPageNumber + 1;
     setup_book(book_file, mupdf::pdf::pdfPageNumber, true);
     setupPng();
 }
diff --git a/reader.h b/reader.h
index 82d59f4..9b7fa97 100644
--- a/reader.h
+++ b/reader.h
@@ -154,9 +154,7 @@ private slots:
     void setupLocalSettingsEnvironment();
     void setupPng();
     void on_pdfScaleSlider_valueChanged(int value);
-
     void on_decreaseScaleBtn_clicked();
-
     void on_increaseScaleBtn_clicked();
 
 private:
diff --git a/reader.ui b/reader.ui
index c3fa415..5f243c7 100644
--- a/reader.ui
+++ b/reader.ui
@@ -705,10 +705,19 @@
                  </property>
                 </widget>
                </item>
-               <item row="2" column="0">
-                <widget class="QPushButton" name="decreaseScaleBtn">
-                 <property name="text">
-                  <string>Decrease scale</string>
+               <item row="2" column="1">
+                <widget class="QSlider" name="pdfScaleSlider">
+                 <property name="minimum">
+                  <number>1</number>
+                 </property>
+                 <property name="maximum">
+                  <number>4</number>
+                 </property>
+                 <property name="pageStep">
+                  <number>1</number>
+                 </property>
+                 <property name="orientation">
+                  <enum>Qt::Horizontal</enum>
                  </property>
                 </widget>
                </item>
@@ -728,19 +737,10 @@
                  </property>
                 </widget>
                </item>
-               <item row="2" column="1">
-                <widget class="QSlider" name="pdfScaleSlider">
-                 <property name="minimum">
-                  <number>1</number>
-                 </property>
-                 <property name="maximum">
-                  <number>4</number>
-                 </property>
-                 <property name="pageStep">
-                  <number>1</number>
-                 </property>
-                 <property name="orientation">
-                  <enum>Qt::Horizontal</enum>
+               <item row="2" column="0">
+                <widget class="QPushButton" name="decreaseScaleBtn">
+                 <property name="text">
+                  <string>Decrease scale</string>
                  </property>
                 </widget>
                </item>