michael/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit.git synced 2024-12-24 20:57:19 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

enhance: remote ssh private key validation

Browse source
This commit is contained in:
leo 2024-05-21 11:52:30 +08:00
parent ef20c174ae
commit 0aea822499
2 changed files with 52 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/ViewModels/AddRemote.cs
View file

@ -1,4 +1,5 @@
using System.ComponentModel.DataAnnotations; using System.ComponentModel.DataAnnotations;
using System.IO;
using System.Threading.Tasks; using System.Threading.Tasks;
namespace SourceGit.ViewModels namespace SourceGit.ViewModels
@ -29,13 +30,18 @@ namespace SourceGit.ViewModels
public bool UseSSH public bool UseSSH
{ {
get => _useSSH; get => _useSSH;
set => SetProperty(ref _useSSH, value); set
{
if (SetProperty(ref _useSSH, value))
ValidateProperty(_sshkey, nameof(SSHKey));
}
} }
[CustomValidation(typeof(AddRemote), nameof(ValidateSSHKey))]
public string SSHKey public string SSHKey
{ {
get; get => _sshkey;
set; set => SetProperty(ref _sshkey, value, true);
} }
public AddRemote(Repository repo) public AddRemote(Repository repo)
@ -71,6 +77,20 @@ namespace SourceGit.ViewModels
return ValidationResult.Success; return ValidationResult.Success;
} }
public static ValidationResult ValidateSSHKey(string sshkey, ValidationContext ctx)
{
if (ctx.ObjectInstance is AddRemote add && add._useSSH)
{
if (string.IsNullOrEmpty(sshkey))
return new ValidationResult("SSH private key is required");
if (!File.Exists(sshkey))
return new ValidationResult("Given SSH private key can NOT be found!");
}
return ValidationResult.Success;
}
public override Task<bool> Sure() public override Task<bool> Sure()
{ {
_repo.SetWatcherEnabled(false); _repo.SetWatcherEnabled(false);
@ -84,11 +104,8 @@ namespace SourceGit.ViewModels
SetProgressDescription("Fetching from added remote ..."); SetProgressDescription("Fetching from added remote ...");
new Commands.Fetch(_repo.FullPath, _name, true, SetProgressDescription).Exec(); new Commands.Fetch(_repo.FullPath, _name, true, SetProgressDescription).Exec();
if (_useSSH)
{
SetProgressDescription("Post processing ..."); SetProgressDescription("Post processing ...");
new Commands.Config(_repo.FullPath).Set($"remote.{_name}.sshkey", SSHKey); new Commands.Config(_repo.FullPath).Set($"remote.{_name}.sshkey", _useSSH ? SSHKey : null);
}
} }
CallUIThread(() => CallUIThread(() =>
{ {
@ -103,5 +120,6 @@ namespace SourceGit.ViewModels
private string _name = string.Empty; private string _name = string.Empty;
private string _url = string.Empty; private string _url = string.Empty;
private bool _useSSH = false; private bool _useSSH = false;
private string _sshkey = string.Empty;
} }
} }

32
src/ViewModels/EditRemote.cs
View file

@ -1,4 +1,5 @@
using System.ComponentModel.DataAnnotations; using System.ComponentModel.DataAnnotations;
using System.IO;
using System.Threading.Tasks; using System.Threading.Tasks;
namespace SourceGit.ViewModels namespace SourceGit.ViewModels
@ -29,13 +30,18 @@ namespace SourceGit.ViewModels
public bool UseSSH public bool UseSSH
{ {
get => _useSSH; get => _useSSH;
set => SetProperty(ref _useSSH, value); set
{
if (SetProperty(ref _useSSH, value))
ValidateProperty(_sshkey, nameof(SSHKey));
}
} }
[CustomValidation(typeof(EditRemote), nameof(ValidateSSHKey))]
public string SSHKey public string SSHKey
{ {
get; get => _sshkey;
set; set => SetProperty(ref _sshkey, value, true);
} }
public EditRemote(Repository repo, Models.Remote remote) public EditRemote(Repository repo, Models.Remote remote)
@ -85,6 +91,20 @@ namespace SourceGit.ViewModels
return ValidationResult.Success; return ValidationResult.Success;
} }
public static ValidationResult ValidateSSHKey(string sshkey, ValidationContext ctx)
{
if (ctx.ObjectInstance is EditRemote edit && edit.UseSSH)
{
if (string.IsNullOrEmpty(sshkey))
return new ValidationResult("SSH private key is required");
if (!File.Exists(sshkey))
return new ValidationResult("Given SSH private key can NOT be found!");
}
return ValidationResult.Success;
}
public override Task<bool> Sure() public override Task<bool> Sure()
{ {
_repo.SetWatcherEnabled(false); _repo.SetWatcherEnabled(false);
@ -106,11 +126,8 @@ namespace SourceGit.ViewModels
_remote.URL = _url; _remote.URL = _url;
} }
if (_useSSH)
{
SetProgressDescription("Post processing ..."); SetProgressDescription("Post processing ...");
new Commands.Config(_repo.FullPath).Set($"remote.{_name}.sshkey", SSHKey); new Commands.Config(_repo.FullPath).Set($"remote.{_name}.sshkey", _useSSH ? SSHKey : null);
}
CallUIThread(() => _repo.SetWatcherEnabled(true)); CallUIThread(() => _repo.SetWatcherEnabled(true));
return true; return true;
@ -122,5 +139,6 @@ namespace SourceGit.ViewModels
private string _name = string.Empty; private string _name = string.Empty;
private string _url = string.Empty; private string _url = string.Empty;
private bool _useSSH = false; private bool _useSSH = false;
private string _sshkey = string.Empty;
} }
} }