From 1161738df91fbb4b14ed5f8b64798469016cde82 Mon Sep 17 00:00:00 2001
From: leo <longshuang@msn.cn>
Date: Wed, 29 May 2024 11:20:15 +0800
Subject: [PATCH 1/2] enhance: a more adaptable regular expression for remote
 URLs (#149)

---
 src/Models/Remote.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Models/Remote.cs b/src/Models/Remote.cs
index c1cce340..75ca961f 100644
--- a/src/Models/Remote.cs
+++ b/src/Models/Remote.cs
@@ -4,11 +4,11 @@ namespace SourceGit.Models
 {
     public partial class Remote
     {
-        [GeneratedRegex(@"^http[s]?://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/]+/[\w\-\.]+\.git$")]
+        [GeneratedRegex(@"^http[s]?://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/]+/[\w\-\.]+(\.git)?$")]
         private static partial Regex REG_HTTPS();
-        [GeneratedRegex(@"^[\w\-]+@[\w\.\-]+(\:[0-9]+)?:[\w\-/]+/[\w\-\.]+\.git$")]
+        [GeneratedRegex(@"^[\w\-]+@[\w\.\-]+(\:[0-9]+)?:[\w\-/]+/[\w\-\.]+(\.git)?$")]
         private static partial Regex REG_SSH1();
-        [GeneratedRegex(@"^ssh://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/]+/[\w\-\.]+\.git$")]
+        [GeneratedRegex(@"^ssh://([\w\-]+@)?[\w\.\-]+(\:[0-9]+)?/[\w\-/]+/[\w\-\.]+(\.git)?$")]
         private static partial Regex REG_SSH2();
 
         private static readonly Regex[] URL_FORMATS = [

From 69f9dceece4ea7fe91d19759e6c2250aa4e88462 Mon Sep 17 00:00:00 2001
From: leo <longshuang@msn.cn>
Date: Wed, 29 May 2024 12:50:26 +0800
Subject: [PATCH 2/2] feature: new way to display changes of submodules

---
 src/Models/DiffResult.cs          |  6 +++++
 src/Resources/Locales/en_US.axaml |  2 ++
 src/Resources/Locales/zh_CN.axaml |  2 ++
 src/Resources/Styles.axaml        |  2 +-
 src/ViewModels/DiffContext.cs     | 29 ++++++++++++++++++++---
 src/Views/CommitBaseInfo.axaml    |  3 ---
 src/Views/CommitBaseInfo.axaml.cs | 15 +++++++++---
 src/Views/CommitDetail.axaml      |  7 ++++--
 src/Views/DiffView.axaml          | 38 +++++++++++++++++++++++++++++++
 9 files changed, 92 insertions(+), 12 deletions(-)

diff --git a/src/Models/DiffResult.cs b/src/Models/DiffResult.cs
index 8a72b35d..d9d21031 100644
--- a/src/Models/DiffResult.cs
+++ b/src/Models/DiffResult.cs
@@ -582,6 +582,12 @@ namespace SourceGit.Models
         public string New { get; set; } = string.Empty;
     }
 
+    public class SubmoduleDiff
+    {
+        public Commit Old { get; set; } = null;
+        public Commit New { get; set; } = null;
+    }
+
     public class DiffResult
     {
         public bool IsBinary { get; set; } = false;
diff --git a/src/Resources/Locales/en_US.axaml b/src/Resources/Locales/en_US.axaml
index bc2bc9c0..d580b82b 100644
--- a/src/Resources/Locales/en_US.axaml
+++ b/src/Resources/Locales/en_US.axaml
@@ -161,6 +161,8 @@
   <x:String x:Key="Text.Diff.NoChange" xml:space="preserve">NO CHANGES OR ONLY EOL CHANGES</x:String>
   <x:String x:Key="Text.Diff.Prev" xml:space="preserve">Previous Difference</x:String>
   <x:String x:Key="Text.Diff.SideBySide" xml:space="preserve">Side-By-Side Diff</x:String>
+  <x:String x:Key="Text.Diff.Submodule" xml:space="preserve">SUBMODULE</x:String>
+  <x:String x:Key="Text.Diff.Submodule.New" xml:space="preserve">NEW</x:String>
   <x:String x:Key="Text.Diff.SyntaxHighlight" xml:space="preserve">Syntax Highlighting</x:String>
   <x:String x:Key="Text.Diff.UseMerger" xml:space="preserve">Open In Merge Tool</x:String>
   <x:String x:Key="Text.Diff.VisualLines.Decr" xml:space="preserve">Decrease Number of Visible Lines</x:String>
diff --git a/src/Resources/Locales/zh_CN.axaml b/src/Resources/Locales/zh_CN.axaml
index 3dffd574..12ec9409 100644
--- a/src/Resources/Locales/zh_CN.axaml
+++ b/src/Resources/Locales/zh_CN.axaml
@@ -161,6 +161,8 @@
   <x:String x:Key="Text.Diff.NoChange" xml:space="preserve">没有变更或仅有换行符差异</x:String>
   <x:String x:Key="Text.Diff.Prev" xml:space="preserve">上一个差异</x:String>
   <x:String x:Key="Text.Diff.SideBySide" xml:space="preserve">分列对比</x:String>
+  <x:String x:Key="Text.Diff.Submodule" xml:space="preserve">子模块</x:String>
+  <x:String x:Key="Text.Diff.Submodule.New" xml:space="preserve">新增</x:String>
   <x:String x:Key="Text.Diff.SyntaxHighlight" xml:space="preserve">语法高亮</x:String>
   <x:String x:Key="Text.Diff.UseMerger" xml:space="preserve">使用外部合并工具查看</x:String>
   <x:String x:Key="Text.Diff.VisualLines.Decr" xml:space="preserve">减少可见的行数</x:String>
diff --git a/src/Resources/Styles.axaml b/src/Resources/Styles.axaml
index 376f9424..2f8bb671 100644
--- a/src/Resources/Styles.axaml
+++ b/src/Resources/Styles.axaml
@@ -72,7 +72,7 @@
   <Style Selector="TextBlock.italic">
     <Setter Property="FontStyle" Value="Italic"/>
   </Style>
-  <Style Selector="TextBlock.monospace">
+  <Style Selector="TextBlock.monospace, SelectableTextBlock.monospace">
     <Setter Property="FontFamily" Value="{Binding Source={x:Static vm:Preference.Instance}, Path=MonospaceFont}"/>
   </Style>
   <Style Selector="TextBlock.group_header_label">
diff --git a/src/ViewModels/DiffContext.cs b/src/ViewModels/DiffContext.cs
index 3aad22ea..580ebd25 100644
--- a/src/ViewModels/DiffContext.cs
+++ b/src/ViewModels/DiffContext.cs
@@ -123,8 +123,31 @@ namespace SourceGit.ViewModels
 
                 if (latest.TextDiff != null)
                 {
-                    latest.TextDiff.File = _option.Path;
-                    rs = latest.TextDiff;
+                    var repo = Preference.FindRepository(_repo);
+                    if (repo != null && repo.Submodules.Contains(_option.Path)) 
+                    {
+                        var submoduleDiff = new Models.SubmoduleDiff();
+                        var submoduleRoot = $"{_repo}/{_option.Path}".Replace("\\", "/");
+                        foreach (var line in latest.TextDiff.Lines)
+                        {
+                            if (line.Type == Models.TextDiffLineType.Added)
+                            {
+                                var sha = line.Content.Substring("Subproject commit ".Length);
+                                submoduleDiff.New = new Commands.QuerySingleCommit(submoduleRoot, sha).Result();
+                            }
+                            else if (line.Type == Models.TextDiffLineType.Deleted)
+                            {
+                                var sha = line.Content.Substring("Subproject commit ".Length);
+                                submoduleDiff.Old = new Commands.QuerySingleCommit(submoduleRoot, sha).Result();
+                            }
+                        }
+                        rs = submoduleDiff;
+                    }
+                    else
+                    {
+                        latest.TextDiff.File = _option.Path;
+                        rs = latest.TextDiff;
+                    }
                 }
                 else if (latest.IsBinary)
                 {
@@ -182,7 +205,7 @@ namespace SourceGit.ViewModels
 
                     FileModeChange = latest.FileModeChange;
                     Content = rs;
-                    IsTextDiff = latest.TextDiff != null;
+                    IsTextDiff = rs is Models.TextDiff;
                     IsLoading = false;
                 });
             });
diff --git a/src/Views/CommitBaseInfo.axaml b/src/Views/CommitBaseInfo.axaml
index 87313098..9e629b35 100644
--- a/src/Views/CommitBaseInfo.axaml
+++ b/src/Views/CommitBaseInfo.axaml
@@ -111,9 +111,6 @@
             <SelectableTextBlock Text="{Binding FullMessage}" FontFamily="{Binding Source={x:Static vm:Preference.Instance}, Path=MonospaceFont}" TextWrapping="Wrap"/>
           </ScrollViewer>
         </Grid>
-
-        <!-- Line -->
-        <Rectangle Height=".65" Margin="8" Fill="{DynamicResource Brush.Border2}" VerticalAlignment="Center"/>
       </StackPanel>
     </DataTemplate>
   </UserControl.DataTemplates>
diff --git a/src/Views/CommitBaseInfo.axaml.cs b/src/Views/CommitBaseInfo.axaml.cs
index 1b873bb7..a4775570 100644
--- a/src/Views/CommitBaseInfo.axaml.cs
+++ b/src/Views/CommitBaseInfo.axaml.cs
@@ -1,3 +1,4 @@
+using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Input;
 
@@ -5,6 +6,15 @@ namespace SourceGit.Views
 {
     public partial class CommitBaseInfo : UserControl
     {
+        public static readonly StyledProperty<bool> CanNavigateProperty =
+            AvaloniaProperty.Register<CommitBaseInfo, bool>(nameof(CanNavigate), true);
+
+        public bool CanNavigate
+        {
+            get => GetValue(CanNavigateProperty);
+            set => SetValue(CanNavigateProperty, value);
+        }
+
         public CommitBaseInfo()
         {
             InitializeComponent();
@@ -12,10 +22,9 @@ namespace SourceGit.Views
 
         private void OnParentSHAPressed(object sender, PointerPressedEventArgs e)
         {
-            if (DataContext is ViewModels.CommitDetail detail)
-            {
+            if (DataContext is ViewModels.CommitDetail detail && CanNavigate)
                 detail.NavigateTo((sender as Control).DataContext as string);
-            }
+            
             e.Handled = true;
         }
     }
diff --git a/src/Views/CommitDetail.axaml b/src/Views/CommitDetail.axaml
index 04972c42..508ee910 100644
--- a/src/Views/CommitDetail.axaml
+++ b/src/Views/CommitDetail.axaml
@@ -17,12 +17,15 @@
         <TextBlock Classes="tab_header" Text="{DynamicResource Text.CommitDetail.Info}"/>
       </TabItem.Header>
 
-      <Grid RowDefinitions="Auto,*">
+      <Grid RowDefinitions="Auto,1,*">
         <!-- Base Information -->
         <v:CommitBaseInfo Grid.Row="0" Content="{Binding Commit}"/>
 
+        <!-- Line -->
+        <Rectangle Grid.Row="1" Height=".65" Margin="8" Fill="{DynamicResource Brush.Border2}" VerticalAlignment="Center"/>
+
         <!-- Change List -->
-        <DataGrid Grid.Row="1"
+        <DataGrid Grid.Row="2"
                   Background="Transparent"
                   ItemsSource="{Binding Changes}"
                   SelectionMode="Single"
diff --git a/src/Views/DiffView.axaml b/src/Views/DiffView.axaml
index 6fa344fd..e7646711 100644
--- a/src/Views/DiffView.axaml
+++ b/src/Views/DiffView.axaml
@@ -126,6 +126,44 @@
             </StackPanel>
           </DataTemplate>
 
+          <!-- Submodule Diff -->
+          <DataTemplate DataType="m:SubmoduleDiff">
+            <Grid Background="{DynamicResource Brush.Contents}" RowDefinitions="Auto,*">
+              <TextBlock Grid.Row="0"
+                         Text="{DynamicResource Text.Diff.Submodule}"
+                         Margin="8,8,8,8"
+                         FontSize="18" FontWeight="Bold"
+                         Foreground="{DynamicResource Brush.FG2}"
+                         HorizontalAlignment="Center"/>
+
+              <ScrollViewer Grid.Row="1" HorizontalScrollBarVisibility="Disabled" VerticalScrollBarVisibility="Auto">
+                <StackPanel Orientation="Vertical" Margin="8,0">
+                  <Border IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNotNull}}">
+                    <ContentControl Content="{Binding Old}">
+                      <ContentControl.DataTemplates>
+                        <DataTemplate DataType="m:Commit">
+                          <Border Margin="0,0,0,8" BorderThickness="1" BorderBrush="{DynamicResource Brush.Border1}" Background="{DynamicResource Brush.Window}">
+                            <v:CommitBaseInfo MaxHeight="256" Margin="0,0,0,4" CanNavigate="False" Content="{Binding}"/>
+                          </Border>
+                        </DataTemplate>
+                      </ContentControl.DataTemplates>
+                    </ContentControl>
+                  </Border>
+
+                  <Border Height="16" HorizontalAlignment="Center" Background="Green" CornerRadius="8" IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNull}}">
+                    <TextBlock Classes="monospace" Text="{DynamicResource Text.Diff.Submodule.New}" Margin="8,0" FontSize="10"/>
+                  </Border>
+
+                  <Path Width="16" Height="16" Data="{StaticResource Icons.DoubleDown}" HorizontalAlignment="Center" IsVisible="{Binding Old, Converter={x:Static ObjectConverters.IsNotNull}}"/>
+
+                  <Border Margin="0,8,0,0" BorderThickness="1" BorderBrush="Green" Background="{DynamicResource Brush.Window}">
+                    <v:CommitBaseInfo MaxHeight="256" Margin="0,0,0,4" CanNavigate="False" Content="{Binding New}"/>
+                  </Border>
+                </StackPanel>
+              </ScrollViewer>
+            </Grid>
+          </DataTemplate>
+
           <!-- Image Diff -->
           <DataTemplate DataType="m:ImageDiff">
             <Grid RowDefinitions="Auto,*,Auto" HorizontalAlignment="Center" VerticalAlignment="Center" Margin="8,8,8,0">