fix: the way to deal with local changes did not update after radio toggle changed (#748)

src/Views/Checkout.axaml

@@ -33,21 +33,20 @@
                  Margin="0,0,8,0"
                  Text="{DynamicResource Text.Checkout.LocalChanges}"/>
       <WrapPanel Grid.Row="1" Grid.Column="1" Orientation="Horizontal" VerticalAlignment="Center">        
-        <WrapPanel.Resources>
-          <ac:EnumToBoolConverter x:Key="EnumToBoolConverter"/>
-        </WrapPanel.Resources>
-        
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.DoNothing}"
+                     x:Name="RadioDoNothing"
                      GroupName="LocalChanges"
                      Margin="0,0,8,0"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.DoNothing}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.StashAndReply}"
+                     x:Name="RadioStashAndReply"
                      GroupName="LocalChanges"
                      Margin="0,0,8,0"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.StashAndReaply}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.Discard}"
+                     x:Name="RadioDiscard"
                      GroupName="LocalChanges"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.Discard}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
       </WrapPanel>
     </Grid>
   </StackPanel>

src/Views/Checkout.axaml.cs

@@ -1,4 +1,5 @@
 using Avalonia.Controls;
+using Avalonia.Interactivity;
 
 namespace SourceGit.Views
 {
@@ -8,5 +9,51 @@ namespace SourceGit.Views
         {
             InitializeComponent();
         }
+
+        protected override void OnLoaded(RoutedEventArgs e)
+        {
+            base.OnLoaded(e);
+
+            var vm = DataContext as ViewModels.Checkout;
+            if (vm == null)
+                return;
+
+            switch (vm.PreAction)
+            {
+                case Models.DealWithLocalChanges.DoNothing:
+                    RadioDoNothing.IsChecked = true;
+                    break;
+                case Models.DealWithLocalChanges.StashAndReaply:
+                    RadioStashAndReply.IsChecked = true;
+                    break;
+                default:
+                    RadioDiscard.IsChecked = true;
+                    break;
+            }
+        }
+
+        private void OnLocalChangeActionIsCheckedChanged(object sender, RoutedEventArgs e)
+        {
+            var vm = DataContext as ViewModels.Checkout;
+            if (vm == null)
+                return;
+
+            if (RadioDoNothing.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.DoNothing)
+                    vm.PreAction = Models.DealWithLocalChanges.DoNothing;
+                return;
+            }
+
+            if (RadioStashAndReply.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.StashAndReaply)
+                    vm.PreAction = Models.DealWithLocalChanges.StashAndReaply;
+                return;
+            }
+
+            if (vm.PreAction != Models.DealWithLocalChanges.Discard)
+                vm.PreAction = Models.DealWithLocalChanges.Discard;
+        }
     }
 }

src/Views/CreateBranch.axaml

@@ -69,21 +69,20 @@
                  Margin="0,0,8,0"
                  Text="{DynamicResource Text.CreateBranch.LocalChanges}"/>
       <WrapPanel Grid.Row="2" Grid.Column="1" Orientation="Horizontal" VerticalAlignment="Center">
-        <WrapPanel.Resources>
-          <ac:EnumToBoolConverter x:Key="EnumToBoolConverter"/>
-        </WrapPanel.Resources>
-
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.DoNothing}"
+                     x:Name="RadioDoNothing"
                      GroupName="LocalChanges"
                      Margin="0,0,8,0"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.DoNothing}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.StashAndReply}"
+                     x:Name="RadioStashAndReply"
                      GroupName="LocalChanges"
                      Margin="0,0,8,0"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.StashAndReaply}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.CreateBranch.LocalChanges.Discard}"
+                     x:Name="RadioDiscard"
                      GroupName="LocalChanges"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.Discard}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
       </WrapPanel>
       
       <CheckBox Grid.Row="3" Grid.Column="1"

src/Views/CreateBranch.axaml.cs

@@ -1,4 +1,5 @@
 using Avalonia.Controls;
+using Avalonia.Interactivity;
 
 namespace SourceGit.Views
 {
@@ -8,5 +9,51 @@ namespace SourceGit.Views
         {
             InitializeComponent();
         }
+
+        protected override void OnLoaded(RoutedEventArgs e)
+        {
+            base.OnLoaded(e);
+
+            var vm = DataContext as ViewModels.CreateBranch;
+            if (vm == null)
+                return;
+
+            switch (vm.PreAction)
+            {
+                case Models.DealWithLocalChanges.DoNothing:
+                    RadioDoNothing.IsChecked = true;
+                    break;
+                case Models.DealWithLocalChanges.StashAndReaply:
+                    RadioStashAndReply.IsChecked = true;
+                    break;
+                default:
+                    RadioDiscard.IsChecked = true;
+                    break;
+            }
+        }
+
+        private void OnLocalChangeActionIsCheckedChanged(object sender, RoutedEventArgs e)
+        {
+            var vm = DataContext as ViewModels.CreateBranch;
+            if (vm == null)
+                return;
+
+            if (RadioDoNothing.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.DoNothing)
+                    vm.PreAction = Models.DealWithLocalChanges.DoNothing;
+                return;
+            }
+
+            if (RadioStashAndReply.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.StashAndReaply)
+                    vm.PreAction = Models.DealWithLocalChanges.StashAndReaply;
+                return;
+            }
+
+            if (vm.PreAction != Models.DealWithLocalChanges.Discard)
+                vm.PreAction = Models.DealWithLocalChanges.Discard;
+        }
     }
 }

src/Views/Pull.axaml

@@ -77,21 +77,20 @@
                  Margin="0,0,8,0"
                  Text="{DynamicResource Text.Pull.LocalChanges}"/>
       <WrapPanel Grid.Row="3" Grid.Column="1" Orientation="Horizontal" VerticalAlignment="Center">
-        <WrapPanel.Resources>
-          <ac:EnumToBoolConverter x:Key="EnumToBoolConverter"/>
-        </WrapPanel.Resources>
-
         <RadioButton Content="{DynamicResource Text.Pull.LocalChanges.DoNothing}"
+                     x:Name="RadioDoNothing"
                      Margin="0,0,8,0"
                      GroupName="LocalChanges"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.DoNothing}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.Pull.LocalChanges.StashAndReply}"
+                     x:Name="RadioStashAndReply"
                      Margin="0,0,8,0"
                      GroupName="LocalChanges"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.StashAndReaply}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
         <RadioButton Content="{DynamicResource Text.Pull.LocalChanges.Discard}"
+                     x:Name="RadioDiscard"
                      GroupName="LocalChanges"
-                     IsChecked="{Binding PreAction, Mode=TwoWay, Converter={StaticResource EnumToBoolConverter}, ConverterParameter={x:Static m:DealWithLocalChanges.Discard}}"/>
+                     IsCheckedChanged="OnLocalChangeActionIsCheckedChanged"/>
       </WrapPanel>
       
       <CheckBox Grid.Row="4" Grid.Column="1"

src/Views/Pull.axaml.cs

@@ -1,4 +1,5 @@
 using Avalonia.Controls;
+using Avalonia.Interactivity;
 
 namespace SourceGit.Views
 {
@@ -8,5 +9,51 @@ namespace SourceGit.Views
         {
             InitializeComponent();
         }
+
+        protected override void OnLoaded(RoutedEventArgs e)
+        {
+            base.OnLoaded(e);
+
+            var vm = DataContext as ViewModels.Pull;
+            if (vm == null)
+                return;
+
+            switch (vm.PreAction)
+            {
+                case Models.DealWithLocalChanges.DoNothing:
+                    RadioDoNothing.IsChecked = true;
+                    break;
+                case Models.DealWithLocalChanges.StashAndReaply:
+                    RadioStashAndReply.IsChecked = true;
+                    break;
+                default:
+                    RadioDiscard.IsChecked = true;
+                    break;
+            }
+        }
+
+        private void OnLocalChangeActionIsCheckedChanged(object sender, RoutedEventArgs e)
+        {
+            var vm = DataContext as ViewModels.Pull;
+            if (vm == null)
+                return;
+
+            if (RadioDoNothing.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.DoNothing)
+                    vm.PreAction = Models.DealWithLocalChanges.DoNothing;
+                return;
+            }
+
+            if (RadioStashAndReply.IsChecked == true)
+            {
+                if (vm.PreAction != Models.DealWithLocalChanges.StashAndReaply)
+                    vm.PreAction = Models.DealWithLocalChanges.StashAndReaply;
+                return;
+            }
+
+            if (vm.PreAction != Models.DealWithLocalChanges.Discard)
+                vm.PreAction = Models.DealWithLocalChanges.Discard;
+        }
     }
 }