michael/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit.git synced 2024-12-26 21:17:20 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

ux: show Unset menu item only if it is necessary (#690)

Browse source 
Signed-off-by: leo <longshuang@msn.cn>
This commit is contained in:
leo 2024-11-14 21:12:18 +08:00
parent 04697093a8
commit 28c93da73b
No known key found for this signature in database
1 changed files with 35 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/Views/FilterModeSwitchButton.axaml.cs
View file

@ -71,20 +71,26 @@ namespace SourceGit.Views
if (button == null) if (button == null)
return; return;
var menu = new ContextMenu();
var mode = Models.FilterMode.None;
if (DataContext is Models.Tag tag) if (DataContext is Models.Tag tag)
{ {
var mode = tag.FilterMode; mode = tag.FilterMode;
var none = new MenuItem(); if (mode != Models.FilterMode.None)
none.Icon = App.CreateMenuIcon("Icons.Eye"); {
none.Header = App.Text("Repository.FilterCommits.Default"); var unset = new MenuItem();
none.IsEnabled = mode != Models.FilterMode.None; unset.Header = App.Text("Repository.FilterCommits.Default");
none.Click += (_, ev) => unset.Click += (_, ev) =>
{ {
UpdateTagFilterMode(repo, tag, Models.FilterMode.None); UpdateTagFilterMode(repo, tag, Models.FilterMode.None);
ev.Handled = true; ev.Handled = true;
}; };
menu.Items.Add(unset);
menu.Items.Add(new MenuItem() { Header = "-" });
}
var include = new MenuItem(); var include = new MenuItem();
include.Icon = App.CreateMenuIcon("Icons.Filter"); include.Icon = App.CreateMenuIcon("Icons.Filter");
include.Header = App.Text("Repository.FilterCommits.Include"); include.Header = App.Text("Repository.FilterCommits.Include");
@ -105,33 +111,27 @@ namespace SourceGit.Views
ev.Handled = true; ev.Handled = true;
}; };
var menu = new ContextMenu();
menu.Items.Add(none);
menu.Items.Add(include); menu.Items.Add(include);
menu.Items.Add(exclude); menu.Items.Add(exclude);
if (mode == Models.FilterMode.None)
{
IsContextMenuOpening = true;
menu.Closed += (_, _) => IsContextMenuOpening = false;
}
menu.Open(button);
} }
else if (DataContext is ViewModels.BranchTreeNode node) else if (DataContext is ViewModels.BranchTreeNode node)
{ {
var mode = node.FilterMode; mode = node.FilterMode;
var none = new MenuItem(); if (mode != Models.FilterMode.None)
none.Icon = App.CreateMenuIcon("Icons.Eye"); {
none.Header = App.Text("Repository.FilterCommits.Default"); var unset = new MenuItem();
none.IsEnabled = mode != Models.FilterMode.None; unset.Header = App.Text("Repository.FilterCommits.Default");
none.Click += (_, ev) => unset.Click += (_, ev) =>
{ {
UpdateBranchFilterMode(repo, node, Models.FilterMode.None); UpdateBranchFilterMode(repo, node, Models.FilterMode.None);
ev.Handled = true; ev.Handled = true;
}; };
menu.Items.Add(unset);
menu.Items.Add(new MenuItem() { Header = "-" });
}
var include = new MenuItem(); var include = new MenuItem();
include.Icon = App.CreateMenuIcon("Icons.Filter"); include.Icon = App.CreateMenuIcon("Icons.Filter");
include.Header = App.Text("Repository.FilterCommits.Include"); include.Header = App.Text("Repository.FilterCommits.Include");
@ -152,10 +152,9 @@ namespace SourceGit.Views
ev.Handled = true; ev.Handled = true;
}; };
var menu = new ContextMenu();
menu.Items.Add(none);
menu.Items.Add(include); menu.Items.Add(include);
menu.Items.Add(exclude); menu.Items.Add(exclude);
}
if (mode == Models.FilterMode.None) if (mode == Models.FilterMode.None)
{ {
@ -164,8 +163,6 @@ namespace SourceGit.Views
} }
menu.Open(button); menu.Open(button);
}
e.Handled = true; e.Handled = true;
} }