fix: welcome page should use a shared singleton instance to manage and filter repositories (#117)

src/ViewModels/Launcher.cs

@@ -114,7 +114,7 @@ namespace SourceGit.ViewModels
                     repo.Close();
 
                     last.Node = new RepositoryNode() { Id = Guid.NewGuid().ToString() };
-                    last.Data = new Welcome();
+                    last.Data = Welcome.Instance;
 
                     GC.Collect();
                 }

src/ViewModels/LauncherPage.cs

@@ -27,7 +27,7 @@ namespace SourceGit.ViewModels
         public LauncherPage()
         {
             _node = new RepositoryNode() { Id = Guid.NewGuid().ToString() };
-            _data = new Welcome();
+            _data = Welcome.Instance;
         }
 
         public LauncherPage(RepositoryNode node, Repository repo)

src/ViewModels/Repository.cs

@@ -8,7 +8,6 @@ using Avalonia.Collections;
 using Avalonia.Controls;
 using Avalonia.Media;
 using Avalonia.Media.Imaging;
-using Avalonia.Platform;
 using Avalonia.Threading;
 
 using CommunityToolkit.Mvvm.ComponentModel;

src/ViewModels/Welcome.cs

@@ -9,10 +9,7 @@ namespace SourceGit.ViewModels
 {
     public class Welcome : ObservableObject
     {
-        public bool IsClearSearchVisible
+        public static Welcome Instance => _instance;
-        {
-            get => !string.IsNullOrEmpty(_searchFilter);
-        }
 
         public AvaloniaList<RepositoryNode> RepositoryNodes
         {
@@ -25,10 +22,7 @@ namespace SourceGit.ViewModels
             set
             {
                 if (SetProperty(ref _searchFilter, value))
-                {
                     Referesh();
-                    OnPropertyChanged(nameof(IsClearSearchVisible));
-                }
             }
         }
 
@@ -205,6 +199,7 @@ namespace SourceGit.ViewModels
             }
         }
 
+        private static Welcome _instance = new Welcome();
         private string _searchFilter = string.Empty;
     }
 }

src/Views/Welcome.axaml

@@ -42,7 +42,7 @@
           </TextBox.InnerLeftContent>
 
           <TextBox.InnerRightContent>
-            <Button Classes="icon_button" IsVisible="{Binding IsClearSearchVisible}" Command="{Binding ClearSearchFilter}">
+            <Button Classes="icon_button" IsVisible="{Binding SearchFilter, Converter={x:Static StringConverters.IsNotNullOrEmpty}}" Command="{Binding ClearSearchFilter}">
               <Path Width="16" Height="16" Margin="0,0,0,0" Data="{StaticResource Icons.Clear}" Fill="{DynamicResource Brush.FG1}"/>
             </Button>
           </TextBox.InnerRightContent>