michael/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit.git synced 2025-01-11 23:57:21 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

bug: fix int out of bounds for branch names with long numbers (#612)

Browse source
This commit is contained in:
ybeapps 2024-10-28 13:24:43 +02:00 committed by GitHub
parent 6c390d2f04
commit a363f67f31
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/Models/NumericSort.cs
View file

@ -51,9 +51,16 @@
int result; int result;
if (isDigit1 && isDigit2) if (isDigit1 && isDigit2)
{ {
int num1 = int.Parse(sub1); // compare numeric values
int num2 = int.Parse(sub2); if (sub1.Length == sub2.Length)
result = num1 - num2; {
// if length is the same, lexicographical comparison is good also for numbers
result = string.CompareOrdinal(sub1, sub2);
}
else
{
result = sub1.Length.CompareTo(sub2.Length);
}
} }
else else
{ {