enhance: only dispatch error message if it contains valid data

This commit is contained in:
leo 2024-12-13 10:41:30 +08:00
parent 26923435e7
commit a99bd2e973
No known key found for this signature in database

View file

@ -104,12 +104,8 @@ namespace SourceGit.Commands
catch (Exception e)
{
if (RaiseError)
{
Dispatcher.UIThread.Invoke(() =>
{
App.RaiseException(Context, e.Message);
});
}
Dispatcher.UIThread.Post(() => App.RaiseException(Context, e.Message));
return false;
}
@ -120,15 +116,15 @@ namespace SourceGit.Commands
int exitCode = proc.ExitCode;
proc.Close();
if (!isCancelled && exitCode != 0 && errs.Count > 0)
if (!isCancelled && exitCode != 0)
{
if (RaiseError)
{
Dispatcher.UIThread.Invoke(() =>
{
App.RaiseException(Context, string.Join("\n", errs));
});
var errMsg = string.Join("\n", errs);
if (!string.IsNullOrWhiteSpace(errMsg))
Dispatcher.UIThread.Post(() => App.RaiseException(Context, errMsg));
}
return false;
}