From ad0d1f0ab836de85778a49289d68991967efb611 Mon Sep 17 00:00:00 2001
From: leo <longshuang@msn.cn>
Date: Fri, 21 May 2021 12:43:41 +0800
Subject: [PATCH] fix<Preference>: fix open Preference crash when git.exe is
 not configured

---
 src/Views/Preference.xaml.cs | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/src/Views/Preference.xaml.cs b/src/Views/Preference.xaml.cs
index c6e2ba8d..6382da32 100644
--- a/src/Views/Preference.xaml.cs
+++ b/src/Views/Preference.xaml.cs
@@ -16,10 +16,16 @@ namespace SourceGit.Views {
         public string MergeCmd { get; set; }
 
         public Preference() {
-            User = new Commands.Config().Get("user.name");
-            Email = new Commands.Config().Get("user.email");
-            CRLF = new Commands.Config().Get("core.autocrlf");
-            if (string.IsNullOrEmpty(CRLF)) CRLF = "false";
+            if (Models.Preference.Instance.IsReady) {
+                User = new Commands.Config().Get("user.name");
+                Email = new Commands.Config().Get("user.email");
+                CRLF = new Commands.Config().Get("core.autocrlf");
+                if (string.IsNullOrEmpty(CRLF)) CRLF = "false";
+            } else {
+                User = "";
+                Email = "";
+                CRLF = "false";
+            }
 
             var merger = Models.MergeTool.Supported.Find(x => x.Type == Models.Preference.Instance.MergeTool.Type);
             if (merger != null) MergeCmd = merger.Cmd;
@@ -83,15 +89,17 @@ namespace SourceGit.Views {
         }
 
         private void Quit(object sender, RoutedEventArgs e) {
-            var cmd = new Commands.Config();
-            var oldUser = cmd.Get("user.name");
-            if (oldUser != User) cmd.Set("user.name", User);
+            if (Models.Preference.Instance.IsReady) {
+                var cmd = new Commands.Config();
+                var oldUser = cmd.Get("user.name");
+                if (oldUser != User) cmd.Set("user.name", User);
 
-            var oldEmail = cmd.Get("user.email");
-            if (oldEmail != Email) cmd.Set("user.email", Email);
+                var oldEmail = cmd.Get("user.email");
+                if (oldEmail != Email) cmd.Set("user.email", Email);
 
-            var oldCRLF = cmd.Get("core.autocrlf");
-            if (oldCRLF != CRLF) cmd.Set("core.autocrlf", CRLF);
+                var oldCRLF = cmd.Get("core.autocrlf");
+                if (oldCRLF != CRLF) cmd.Set("core.autocrlf", CRLF);
+            }
 
             Models.Preference.Save();
             Close();